Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: user management supports conditional filtering and sorting #862

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 17, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

用户管理列表支持条件筛选和排序,适配:halo-dev/halo#3320

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3290

Screenshots:

image

Special notes for your reviewer:

测试方式:

  1. Halo 需要切换到 Add custom endpoint for listing user conditionally halo#3320 分支。
  2. Console 需要 pnpm build:packages
  3. 测试用户管理的关键词、条件、排序筛选是否工作正常。

Does this PR introduce a user-facing change?

Console 端的用户列表支持条件筛选和排序。

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 17, 2023
@vercel
Copy link

vercel bot commented Feb 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 0:35AM (UTC)

Copy link
Member

@wzrove wzrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, wzrove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 194ff7f into halo-dev:main Feb 20, 2023
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 20, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…o-dev/console#862)

#### What type of PR is this?

/kind feature

#### What this PR does / why we need it:

用户管理列表支持条件筛选和排序,适配:halo-dev#3320

#### Which issue(s) this PR fixes:

Fixes halo-dev#3290

#### Screenshots:

<img width="922" alt="image" src="https://user-images.githubusercontent.com/21301288/219578426-de396dfb-7ece-496e-b740-d7a36321eafb.png">

#### Special notes for your reviewer:

测试方式:

1. Halo 需要切换到 halo-dev#3320 分支。
2. Console 需要 `pnpm build:packages`
3. 测试用户管理的关键词、条件、排序筛选是否工作正常。

#### Does this PR introduce a user-facing change?

```release-note
Console 端的用户列表支持条件筛选和排序。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望为 Console 端的用户管理单独提供接口以支持更多筛选条件
3 participants